Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move and publish CRD checker #224

Merged
merged 1 commit into from
Apr 25, 2024
Merged

chore: move and publish CRD checker #224

merged 1 commit into from
Apr 25, 2024

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Apr 25, 2024

What this PR does / why we need it:

We have some features that require CRD availability and do not use Reconcilers. These features should check that their required CRDs are available before attempting to interact with them.

To support this, move the manager's CRD checker utility into the kubernetes utils package and publish it.

Which issue this PR fixes

Related to https://github.com/Kong/gateway-operator-enterprise/issues/118

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes Nothing user-facing

@rainest rainest requested a review from a team as a code owner April 25, 2024 00:44
@rainest rainest enabled auto-merge (squash) April 25, 2024 00:44
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't notice the test being moved 🤦

@rainest rainest merged commit 649afca into main Apr 25, 2024
13 checks passed
@rainest rainest deleted the chore/publish-crdcheck branch April 25, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants